Skip to content

[WIP] Bumped tsd-jsdoc #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] Bumped tsd-jsdoc #13

wants to merge 2 commits into from

Conversation

mxschmitt
Copy link
Member

No description provided.

@mxschmitt mxschmitt requested a review from irgendwr October 23, 2018 21:33
@irgendwr
Copy link
Member

Uhh good idea but hold on with this one! Last time I checked this broke everything (many things were missing in the tsd file).
Did you test it? I would definitly look at the diff between the old and the newly generated file fist to see if something might be missing.

@irgendwr
Copy link
Member

And the config also needs to be updated as mentioned here.

Its a bit annoying that you changed the required template path from ./node_modules/tsd-jsdoc to ./node_modules/tsd-jsdoc/dist after 2.0.0-beta.3 without mentioning it anywhere.

@mxschmitt mxschmitt changed the title Bumped tsd-jsdoc [WIP] Bumped tsd-jsdoc Oct 23, 2018
@irgendwr
Copy link
Member

replaced by #20

@irgendwr irgendwr closed this Feb 14, 2019
@mxschmitt mxschmitt deleted the bump-tsd-jsdoc branch February 14, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irgendwr irgendwr Awaiting requested review from irgendwr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @irgendwr